Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1350: [FR] Adjust 'R:Tosti' template output #1351

Closed
wants to merge 1 commit into from

Conversation

lasconic
Copy link
Collaborator

@lasconic lasconic commented Aug 9, 2022

Fixes #1350

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 9, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 47.67 ⛔ 47.67 ⛔ 0.00
Method Length 473.00 ⛔ 473.00 ⛔ 0.00
Working memory 15.30 ⛔ 15.30 ⛔ 0.00
Quality 20.30% 20.30% 0.00%
Other metrics Before After Change
Lines 1479 1479 0
Changed files Quality Before Quality After Quality Change
tests/test_fr.py 53.27% 🙂 53.27% 🙂 0.00%
wikidict/lang/fr/init.py 16.55% ⛔ 16.55% ⛔ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
wikidict/lang/fr/init.py last_template_handler 64 ⛔ 575 ⛔ 18 ⛔ 7.18% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
tests/test_fr.py test_parse_word 0 ⭐ 452 ⛔ 10 😞 50.53% 🙂 Try splitting into smaller methods. Extract out complex expressions
tests/test_fr.py test_process_templates 0 ⭐ 320 ⛔ 5 ⭐ 64.25% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Adjust 'R:Tosti' template output
1 participant