Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1477: [FR] Support 'T' template #1488

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Conversation

lasconic
Copy link
Collaborator

@lasconic lasconic commented Jan 5, 2023

Fixes #1477

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 5, 2023

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.23%.

Quality metrics Before After Change
Complexity 11.06 🙂 10.98 🙂 -0.08 👍
Method Length 79.43 🙂 78.40 🙂 -1.03 👍
Working memory 7.30 🙂 7.27 🙂 -0.03 👍
Quality 64.60% 🙂 64.83% 🙂 0.23% 👍
Other metrics Before After Change
Lines 1210 1220 10
Changed files Quality Before Quality After Quality Change
wikidict/lang/fr/template_handlers.py 64.60% 🙂 64.83% 🙂 0.23% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
wikidict/lang/fr/template_handlers.py render_compose_de 41 ⛔ 434 ⛔ 13 😞 17.39% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
wikidict/lang/fr/template_handlers.py render_etyl 22 😞 175 😞 11 😞 39.30% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
wikidict/lang/fr/template_handlers.py render_lien_web 20 😞 238 ⛔ 7 🙂 44.63% 😞 Refactor to reduce nesting. Try splitting into smaller methods
wikidict/lang/fr/template_handlers.py render_cit_ref 10 🙂 159 😞 8 🙂 56.55% 🙂 Try splitting into smaller methods
wikidict/lang/fr/template_handlers.py render_la_verb 5 ⭐ 129 😞 10 😞 60.32% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@lasconic
Copy link
Collaborator Author

lasconic commented Jan 5, 2023

Note : I edited "frottée" on wiktionary since "T" had nothing to do in the etymology section but with this commit we support it.

@BoboTiG BoboTiG merged commit b836a4e into BoboTiG:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Support "T" template
2 participants