-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cli crashes when no name is provided #9
Labels
bug
Something isn't working
Comments
Thanks for the report @JoseKilo :) Would you like to open a PR? |
I've some free time, I will work on it, and add tests at the same time. |
BoboTiG
added a commit
that referenced
this issue
Apr 23, 2023
Also: - Fix Mypy error `PEP 484 prohibits implicit Optional` - Use `shutil.get_terminal_size()` instead of `os.get_terminal_size()` to be able to run tests without hitting `OSError: [Errno 25] Inappropriate ioctl for device` - Support for Python 3.12 - CI to run unit tests - Tests for the CLI entry point
BoboTiG
added a commit
that referenced
this issue
Apr 23, 2023
- Fix Mypy error `PEP 484 prohibits implicit Optional` - Use `shutil.get_terminal_size()` instead of `os.get_terminal_size()` to be able to run tests without hitting `OSError: [Errno 25] Inappropriate ioctl for device` - Support for Python 3.12 - CI to run unit tests - Tests for the CLI entry point
v2.7.0 released with the fix 🎉 |
Amazing ! Thanks a lot !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
HI, nice tool ! Thanks for sharing it.
I've noticed a small bug while using the cli:
If I don't provide a chart name, it crashes without providing much info:
It works if a name is provided:
> candlestick-chart -m json-file -f candles.json --chart-name __NAME__
and even with an empty name:
It looks like the default value for the argument should be a string, changing this line seems to fix it
py-candlestick-chart/src/candlestick_chart/__main__.py
Line 33 in e6a2a0b
I'm using the latest version from PyPI:
> candlestick-chart --version candlestick-chart 2.6.0
The text was updated successfully, but these errors were encountered: