Skip to content
This repository has been archived by the owner on Aug 5, 2019. It is now read-only.

Switched logging to .net tracing infrastructure. #3

Merged
merged 4 commits into from
Sep 27, 2013
Merged

Switched logging to .net tracing infrastructure. #3

merged 4 commits into from
Sep 27, 2013

Conversation

naughtenough
Copy link

More flexible approach.
You can Add multiple trace sources.
You could also potentially add a ReleaseTraceSource class should the need arise.
Trace listeners abound, and can be much faster than ConsoleWrite.

@naughtenough
Copy link
Author

Ah, forgot to mention. I took the timestamp out because most decent trace listeners will do that for you.

@Bobris
Copy link
Owner

Bobris commented Sep 27, 2013

Why you are using 2 accounts? I would merge your changes more happily knowing your development history ...
Ok, thanks for your improvement, even-though I would like to have it even more flexible (to be able to enable debug logging even in release mode with minimal impact to speed).

Bobris added a commit that referenced this pull request Sep 27, 2013
Switched logging to .net tracing infrastructure.
@Bobris Bobris merged commit b5b1e7d into Bobris:master Sep 27, 2013
@naughtenough
Copy link
Author

You probably want all of the changes that I added today as they both address your request of release/debug flexibility and fix a bug in 5314f24 .

gabe-avila Fixed TraceSources string.Format bug d3e258a
gabe-avila Renamed trace source and added release variant. 9546469
gabe-avila Added to every listener in the sample app.co… e233abb

Sorry, I am new to github. I can't tell if I need to create another pull request for this or if you simply get to pull everything im my branch as you wish?

@Bobris
Copy link
Owner

Bobris commented Sep 27, 2013

I see that it merged all your 4 commits. So you don't need to do anything else.

@Bobris
Copy link
Owner

Bobris commented Sep 27, 2013

And congratulate you for your first merged pull request. Enjoy that moment :-) Thanks again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants