Replace windows with windows-sys
#131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 18, 2023
Jake-Shadle
force-pushed
the
replace-windows
branch
from
1739b76
to
7e8fe49
Compare
|
Guessing this isn't of interest, so I'll close |
|
Sorry that you never received a response, but thank you anyway for the PR! Indeed, it is a tradeoff, and it's not clear to me that the change is worth it, which is why I never merged your PR ... |
|
No worries, this patch is easy to maintain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...when not using
winrtfeature.The compile time cost of
windowsis not too bad compared towindows-sysfor the features used by this crate, ~4.4s vs ~0.8s, and unfortunately due to how optional crates and cfg works in cargo we now add the cost ofwindows-syswhen thewinrtfeature is enabled even though it is not used, but I think the inverse of compiling the heavierwindowscrate when it's not needed is worse, but it is a tradeoff.