Update coremidi to 0.8.0 #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works for me |
|
FWIW, coremidi 0.7.0+ doesn't support macOS 10.x because it uses MIDISendEventList and MIDIReceivedEventList. I'm not sure this is something that is important to anyone, just reporting my findings compiling on macOS Catalina 10.15.7. |
Closed
Does that mean that this change should imply a "breaking change" version increase also to midir, i.e. 0.10.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in
coremidi0.8.0 since the previous 0.6.0 don't affect the API used bymidir.You can see the changelog here: https://github.com/chris-zen/coremidi/releases