-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HOCON file type #103
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kehoecj
requested changes
Dec 5, 2023
jd4235
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kehoecj
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good implementation just focusing on .hocon
file extensions for now until we can support targeting different file types.
jackswiney
approved these changes
Dec 11, 2023
kehoecj
added
the
OSS Community Contribution
Contributions from the OSS Community
label
Dec 18, 2023
shiina4119
pushed a commit
to shiina4119/config-file-validator
that referenced
this pull request
Aug 23, 2024
* Add support for HOCON file type * Alphabetize file type
shiina4119
pushed a commit
to shiina4119/config-file-validator
that referenced
this pull request
Oct 4, 2024
* Add support for HOCON file type * Alphabetize file type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR :
Somehing to keep in mind, HOCON has multiple file extensions,
.properties
,.json
, and.conf
as defined in Lightbend's HOCON documentation and Sponge's HOCON guide. But there are also people using the extension.hocon
. I decided to only validate files with.hocon
extension to avoid conflicts with other files that may have the same extension but different configuration language (.properties
,.json
, and.conf
).Closes #64