Add support for .env config files #110 #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can work on it again if you didn't like my implementation. |
kehoecj
added
the
OSS Community Contribution
|
Thanks for the contribution @HakanVardarr ! Looks like you're just missing a few lines in the test data struct to test your .env file validator. |
|
@kehoecj Oh I didn't see that struct :) I am going to look that right now |
kehoecj
added
the
pr-action-requested
|
Interesting addition to the project, thanks |
kehoecj
removed
the
pr-action-requested
kehoecj
reviewed
Mar 27, 2024
kehoecj
added
pr-action-requested
kehoecj
removed
the
waiting-on-maintainer-review
shiina4119
pushed a commit
to shiina4119/config-file-validator
that referenced
this pull request
Aug 23, 2024
* Env file support * Removed test * Added test back * Test Struct
shiina4119
pushed a commit
to shiina4119/config-file-validator
that referenced
this pull request
Oct 4, 2024
* Env file support * Removed test * Added test back * Test Struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented a env validator using go-envparse package, also added a good.env and bad.env to test the env validator.
Closes #110