-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quiet Flag For CLI #124
Quiet Flag For CLI #124
Conversation
Thanks for another PR @HakanVardarr ! Can you take out the env changes so this is a standalone PR? |
@kehoecj I am new to pull request stuff sorry for the mistake. I am trying to learn. :) |
No problem at all! Glad to have you contributing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found the following issue during functional testing. Running >> docker run -v $(pwd)/test:/test cfv:quiet --depth 0 /test
outputs the following to stdout:
Summary: 0 succeeded, 0 failed
Co-authored-by: Clayton Kehoe <118750525+kehoecj@users.noreply.github.com>
@kehoecj I'll look for thath issue |
You're right! The container name threw me off. I re-ran with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - great work
If it is working that is good. 😄 |
Thanks a lot for implementing the quiet mode |
* Env file support * Removed test * Added test back * Test Struct * Quiet flag * Quiet groupby * Removed env changes * removed env tests * Update cmd/validator/validator.go Co-authored-by: Clayton Kehoe <118750525+kehoecj@users.noreply.github.com> --------- Co-authored-by: Clayton Kehoe <118750525+kehoecj@users.noreply.github.com>
* Env file support * Removed test * Added test back * Test Struct * Quiet flag * Quiet groupby * Removed env changes * removed env tests * Update cmd/validator/validator.go Co-authored-by: Clayton Kehoe <118750525+kehoecj@users.noreply.github.com> --------- Co-authored-by: Clayton Kehoe <118750525+kehoecj@users.noreply.github.com>
tried to implement quiet flag. Added a global variable Quiet and WithQuiet function in cli.go. I forgot to remove the env implementation. I took the easy way with the global variable if you don't like it I can try to find another way.
Closed #105