Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiet Flag For CLI #124

Merged
merged 11 commits into from
Mar 29, 2024
Merged

Quiet Flag For CLI #124

merged 11 commits into from
Mar 29, 2024

Conversation

HakanVardarr
Copy link
Contributor

@HakanVardarr HakanVardarr commented Mar 28, 2024

tried to implement quiet flag. Added a global variable Quiet and WithQuiet function in cli.go. I forgot to remove the env implementation. I took the easy way with the global variable if you don't like it I can try to find another way.

Closed #105

@kehoecj kehoecj added the OSS Community Contribution Contributions from the OSS Community label Mar 28, 2024
@kehoecj
Copy link
Collaborator

kehoecj commented Mar 28, 2024

Thanks for another PR @HakanVardarr ! Can you take out the env changes so this is a standalone PR?

@kehoecj kehoecj added the pr-action-requested PR is awaiting feedback from the submitting developer label Mar 28, 2024
@HakanVardarr
Copy link
Contributor Author

@kehoecj I am new to pull request stuff sorry for the mistake. I am trying to learn. :)

@kehoecj
Copy link
Collaborator

kehoecj commented Mar 28, 2024

@kehoecj I am new to pull request stuff sorry for the mistake. I am trying to learn. :)

No problem at all! Glad to have you contributing

@kehoecj kehoecj self-requested a review March 29, 2024 18:01
Copy link
Collaborator

@kehoecj kehoecj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found the following issue during functional testing. Running >> docker run -v $(pwd)/test:/test cfv:quiet --depth 0 /test outputs the following to stdout:

Summary: 0 succeeded, 0 failed

cmd/validator/validator.go Outdated Show resolved Hide resolved
Co-authored-by: Clayton Kehoe <118750525+kehoecj@users.noreply.github.com>
@HakanVardarr
Copy link
Contributor Author

@kehoecj I'll look for thath issue

@HakanVardarr
Copy link
Contributor Author

You didn't pass the quiet flag in the test

 docker run -v $(pwd)/test:/test cfv:quiet --depth 0 /test
docker run -v $(pwd)/test:/test config-file-validator:v1.5.0 --quiet --depth 0 /test

I ran this and I didn't get any output.
Screenshot 2024-03-29 at 21 17 42

@kehoecj
Copy link
Collaborator

kehoecj commented Mar 29, 2024

You didn't pass the quiet flag in the test

 docker run -v $(pwd)/test:/test cfv:quiet --depth 0 /test
docker run -v $(pwd)/test:/test config-file-validator:v1.5.0 --quiet --depth 0 /test

I ran this and I didn't get any output. Screenshot 2024-03-29 at 21 17 42

You're right! The container name threw me off. I re-ran with --quiet and it works as expected. Thanks for QA-ing my QA 😆

Copy link
Collaborator

@kehoecj kehoecj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - great work

@HakanVardarr
Copy link
Contributor Author

You didn't pass the quiet flag in the test

 docker run -v $(pwd)/test:/test cfv:quiet --depth 0 /test
docker run -v $(pwd)/test:/test config-file-validator:v1.5.0 --quiet --depth 0 /test

I ran this and I didn't get any output. Screenshot 2024-03-29 at 21 17 42

You're right! The container name threw me off. I re-ran with --quiet and it works as expected. Thanks for QA-ing my QA 😆

If it is working that is good. 😄

@kehoecj kehoecj merged commit b1c355a into Boeing:main Mar 29, 2024
3 of 4 checks passed
@kehoecj kehoecj removed the pr-action-requested PR is awaiting feedback from the submitting developer label Mar 29, 2024
@HakanVardarr HakanVardarr deleted the quiet branch March 29, 2024 18:31
@ccoVeille
Copy link
Contributor

Thanks a lot for implementing the quiet mode

shiina4119 pushed a commit to shiina4119/config-file-validator that referenced this pull request Aug 23, 2024
* Env file support

* Removed test

* Added test back

* Test Struct

* Quiet flag

* Quiet groupby

* Removed env changes

* removed env tests

* Update cmd/validator/validator.go

Co-authored-by: Clayton Kehoe <118750525+kehoecj@users.noreply.github.com>

---------

Co-authored-by: Clayton Kehoe <118750525+kehoecj@users.noreply.github.com>
shiina4119 pushed a commit to shiina4119/config-file-validator that referenced this pull request Oct 4, 2024
* Env file support

* Removed test

* Added test back

* Test Struct

* Quiet flag

* Quiet groupby

* Removed env changes

* removed env tests

* Update cmd/validator/validator.go

Co-authored-by: Clayton Kehoe <118750525+kehoecj@users.noreply.github.com>

---------

Co-authored-by: Clayton Kehoe <118750525+kehoecj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OSS Community Contribution Contributions from the OSS Community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

output nothing to stdout
3 participants