Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Encode deprecation #28

Closed
bojan88 opened this issue Feb 4, 2016 · 3 comments
Closed

URL Encode deprecation #28

bojan88 opened this issue Feb 4, 2016 · 3 comments
Assignees

Comments

@bojan88
Copy link
Collaborator

bojan88 commented Feb 4, 2016

We don't need url encoded strings, only some special characters escaped

@boomskats
Copy link
Contributor

We can ditch urlencoding for the strings, should speed things up. Need to implement regex based variable assignment rather than the substr and scan bits that we have now

do while (rowpos > 0) ;
* get current row ;
  currentrow = substr(jsonString, rowpos, rowlen) ;
  currentpairnum = 1 ;
  do until (scan(currentrow, currentpairnum, ",") = "") ;
    currentpair = scan(currentrow, currentpairnum, ",") ;
    varname = upcase(strip(compress(scan(currentpair, 1, ":"), '"'))) ;
    varvalue = urldecode(strip(compress(scan(currentpair, 2, ":"), '"'))) ;
    coltype = upcase(put(varname, $coltype.)) ;

@boomskats
Copy link
Contributor

boomskats commented Mar 12, 2017

This is currently being addresed by the development branch and so is duplicate of #26

@cj13579
Copy link
Contributor

cj13579 commented Mar 5, 2020

As per this comment this is a dupe of #26. Closing this issue.

@cj13579 cj13579 closed this as completed Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants