Skip to content
This repository has been archived by the owner on Dec 22, 2019. It is now read-only.

Guzzle6 dependency issue solved #70

Closed
wants to merge 3 commits into from

Conversation

milocosmopolitan
Copy link

changed some code due to guzzle6 dependency issue according to mailgun/mailgun-php 2.0
https://github.com/mailgun/mailgun-php

Hope this helps.

@milocosmopolitan milocosmopolitan mentioned this pull request Jun 25, 2016
@@ -18,7 +18,8 @@
"php": ">=5.5.9",
"illuminate/support": "5.*",
"nesbot/carbon": "^1.20",
"mailgun/mailgun-php": "^1.8"
"mailgun/mailgun-php": "^2.0",
"php-http/guzzle6-adapter": "^1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One should not put this requirement here. This should be added in the user's application. We should let the user decide what library to use to send http messages.

@Nyholm
Copy link
Contributor

Nyholm commented Jul 22, 2016

In my opinion you should only update the Mailgun version. Do not change anything else.

Read more about HTTPlug here: http://docs.php-http.org/en/latest/httplug/library-developers.html

@nickbr5
Copy link

nickbr5 commented Sep 26, 2016

Hi ,

Any news on this?
I would like to update guzzle but i'm stuck because of the usage of this package :s

@johannesschobel
Copy link
Contributor

I think you should NOT use guzzle6 in the provided composer.json file. Note, that the old version of mailgun/mailgun-php did require guzzle5 per default. In this case it was not necessary to include it in this package..

However, in the new version of mailgun/mailgun-php they removed the guzzle dependencies and provide respective information in the README file.

No need to bind people to guzzle6 when using this package.. Keep the dependencies at a minimum!

@Bogardo
Copy link
Owner

Bogardo commented Nov 13, 2016

Please update to the lastest release and review the installation instructions.

@Bogardo Bogardo closed this Nov 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants