Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NalUnit type has valid range 0-31 #114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions RtspClientSharp/MediaParsers/H264Parser.cs
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ private void ProcessNalUnit(ArraySegment<byte> byteSegment, bool hasStartMarker,
int nalUnitType = byteSegment.Array[offset] & 0x1F;
bool nri = ((byteSegment.Array[offset] >> 5) & 3) == 0;

if (!(nalUnitType > 0 && nalUnitType < 24))
if (!(nalUnitType > -1 && nalUnitType < 32))
throw new H264ParserException($"Invalid nal unit type: {nalUnitType}");

if (nalUnitType == 7)
Expand Down Expand Up @@ -286,4 +286,4 @@ private static FrameType GetFrameType(int sliceType)
return FrameType.Unknown;
}
}
}
}