Make queue declaration at RabbitMQ broker lazy #270
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdrijvers
force-pushed
the
lazy-rabbitmq
branch
3 times, most recently
from
84c93db to
31318f7
Compare
timdrijvers
force-pushed
the
lazy-rabbitmq
branch
from
31318f7 to
f9c1a10
Compare
Owner
|
Thanks, I'll take a look at this tomorrow morning. |
timdrijvers
force-pushed
the
lazy-rabbitmq
branch
from
14d2abe to
f4c3f87
Compare
Owner
|
Thanks. I've made some fixes on top of this and merged the changes with rebase. I'll cut a release later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RabbitMQ broker opens a connection on queue declaration. When task files are being discovered and imported, this causes the actors to register and automatically open a connection. This causes unnecessary connections to be opened, even when no task is being pushed or worker is consuming queues. This PR makes the queue declaration lazy.
Following a discussion: https://www.reddit.com/r/dramatiq/comments/eukrh7/lazy_queue_registration_for_rabbitmq/