Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make queue declaration at RabbitMQ broker lazy #270

Closed
wants to merge 2 commits into from

Conversation

timdrijvers
Copy link
Contributor

@timdrijvers timdrijvers commented Jan 31, 2020

The RabbitMQ broker opens a connection on queue declaration. When task files are being discovered and imported, this causes the actors to register and automatically open a connection. This causes unnecessary connections to be opened, even when no task is being pushed or worker is consuming queues. This PR makes the queue declaration lazy.

Following a discussion: https://www.reddit.com/r/dramatiq/comments/eukrh7/lazy_queue_registration_for_rabbitmq/

@timdrijvers timdrijvers force-pushed the lazy-rabbitmq branch 3 times, most recently from 84c93db to 31318f7 Compare Jan 31, 2020
@Bogdanp
Copy link
Owner

@Bogdanp Bogdanp commented Feb 1, 2020

Thanks, I'll take a look at this tomorrow morning.

@Bogdanp Bogdanp added this to the v1.8.0 milestone Feb 1, 2020
@Bogdanp
Copy link
Owner

@Bogdanp Bogdanp commented Feb 2, 2020

Thanks. I've made some fixes on top of this and merged the changes with rebase. I'll cut a release later today.

@Bogdanp Bogdanp closed this Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants