No Case: RLLib 1.3.0 fixed the DQN convergence issue per master branc… #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kiko-Aumond
reviewed
Sep 7, 2021
| @@ -383,41 +384,13 @@ def compute_q_values(policy: Policy, | |||
| return value, logits, dist, state | |||
|
|
|||
|
|
|||
| def _adjust_nstep(n_step, gamma, obs, actions, rewards, new_obs, dones): | |||
There was a problem hiding this comment.
Can you document all input variables in this method?
There was a problem hiding this comment.
Can you document all input variables in this method?
This method is moved to the one in rllib/evaluation/postprocessing.py and I think Sven added the doc string for the method.
There was a problem hiding this comment.
It'd be useful to have documentation and type annotations for those parameters.
There was a problem hiding this comment.
It'd be useful to have documentation and type annotations for those parameters.
Yes, the type annotation is included there.
There was a problem hiding this comment.
Kiko-Aumond
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…h fix.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.