Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Video scrubbing #3274

Closed
XCrownedClownsX opened this issue Feb 21, 2022 · 5 comments
Closed

[Feature Request]: Video scrubbing #3274

XCrownedClownsX opened this issue Feb 21, 2022 · 5 comments

Comments

@XCrownedClownsX
Copy link

Describe the feature you'd like

Scrubbing in the video player to allow moving the slider along the timeline back and forth in order to get the needed point right away, without waiting when the track reaches this moment “in a natural way”.

Describe the benefits this feature would bring to BookStack users

Our use case is uploading videos recorded from Teams to a Bookstack page with multiple video files for our training chapter. Would be nice if when users return to the page they don't have to wait for the video to slowly play again back to where they were, they could just move the slider forward and pick up where they left off.

Additional context

No response

@s00500
Copy link

s00500 commented Mar 23, 2022

There also seems a bug involved here: in Firefox one can at least jump to places in a video, but in chrome based browsers the bar just jumps back and the video continues where it was... seems to be a chrome thing with the video tag... have not found a nice way around it yet

@ssddanbrown
Copy link
Member

Related to #882, May close/merge this into that in the future.

If you host the video somewhere that can properly support range requests (Most webservers can do this) then scrubbing should work fine. BookStack's attachment serving does not currently support range requests hence the lack of scrubbing.

@jennso
Copy link

jennso commented Jul 15, 2022

Has anyone found a workaround for this or has it been implemented, my goal is to have embedded mp4 videos that can be scrubbed and skip while playing.

Thank You!

@LHBL2003
Copy link

I would also be happy if it works in Chrome. in Firefox, fast forwarding it still works.

@ssddanbrown ssddanbrown added this to the Next Feature Release milestone Jan 17, 2024
@ssddanbrown ssddanbrown changed the title [Feature Request]: Video Player overhaul/ Video scrubbing [Feature Request]: Video scrubbing Jan 17, 2024
@ssddanbrown
Copy link
Member

Range request support has been added in PR #4758, to be part of the next feature release.
This allows video scrubbing. There are some limitations for this, if using cloud (s3) storage but those concerns could be raised separately if an issue, otherwise should work for most cases.
That PR also eases adding videos from attachments by adding them as a video embed automatically when dragged in from the attachments bar (or when the link button is used).

Note though, browsers can treat videos in different ways, likely depending on a number of factors. Worked fine in my testing although Safari could act strange and often still want to download the whole video in a single big chunk, although this may change depending on network conditions and other factors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants