Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update markdown-it JS package #4858

Closed
ssddanbrown opened this issue Feb 20, 2024 · 1 comment
Closed

Update markdown-it JS package #4858

ssddanbrown opened this issue Feb 20, 2024 · 1 comment
Labels
💻 Front-End 🔧 Maintenance
Milestone
v24.05

Comments

@ssddanbrown
Copy link
Member

Have been holding this back since it inflates bundle size by 10%, so need to see if we can properly address.
Don't think ESBuild is properly tree shaking "entities" sub package which inflates size.

I think we should be able to remove the punycode package from our own package.json, since I think this is now a specified dependency of markdown-it.
@ssddanbrown ssddanbrown added this to the Next Feature Release milestone Mar 9, 2024
ssddanbrown added a commit that referenced this issue Apr 8, 2024
@ssddanbrown
JS Build: Split markdown to own file, updated packages
f5e6f95 
Markdown-related code was growing, representing half of app.js main
bundle code while only being needed in one view/scenario.
This extracts markdown related code to its own built file.
Related to #4858
@ssddanbrown ssddanbrown mentioned this issue Apr 8, 2024
Merged
@ssddanbrown
Copy link
Member Author

Decided to split out MD code instead since, when coming back to this, that's the obvious route with md code using up half of the main app bundle size. Related PR: #4930
10% as separate bundle is not really significant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 Front-End 🔧 Maintenance
Milestone
v24.05
Development

No branches or pull requests
1 participant
@ssddanbrown