Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumb books & shelves lists are ordered by id not name #4876

Closed
melat0nin opened this issue Feb 28, 2024 · 1 comment
Closed

Breadcrumb books & shelves lists are ordered by id not name #4876

melat0nin opened this issue Feb 28, 2024 · 1 comment
Labels
Milestone

Comments

@melat0nin
Copy link

Describe the Bug

The order of books within the breadcrumb dropdowns (i.e. when you click the arrow) is done by the books' id, rather than by name (or any other method). This is counter-intuitive if the books weren't added to the instance in alphabetical order.

Steps to Reproduce

  1. Create >1 book, using names in non-alphabetical order (i.e. 'Beta Book' then 'Alpha Book')
  2. Within a book, click the drop-down in the breadcrumbs to show the other books at the same level
  3. Observe that they aren't alphabetical

Expected Behaviour

Either the drop-down should by default order the books alphabetically, or there should be an option to select the ordering (perhaps manually, in line with the sorting available for chapters/pages within books).

Screenshots or Additional Context

No response

Browser Details

No response

Exact BookStack Version

v23.12.2

@melat0nin melat0nin changed the title Books in breadcrumb drop-downs are ordered by id not name Books in breadcrumb drop-downs are ordered by id not name Feb 28, 2024
@ssddanbrown ssddanbrown added this to the v24.02.1 milestone Mar 9, 2024
@ssddanbrown ssddanbrown changed the title Books in breadcrumb drop-downs are ordered by id not name Breadcrumb books & shelve lists are ordered by id not name Mar 9, 2024
@ssddanbrown ssddanbrown changed the title Breadcrumb books & shelve lists are ordered by id not name Breadcrumb books & shelves lists are ordered by id not name Mar 9, 2024
ssddanbrown added a commit that referenced this issue Mar 9, 2024
Previously in database order (id) which is not predictable
nor parsable for users.
For #4876
@ssddanbrown
Copy link
Member

ssddanbrown commented Mar 9, 2024

Thanks for reporting @melat0nin.
This has been fixed in b7d4bd5, with tests to cover, to ensure name order is used for default (Non-shelf context) book and shelf lists.

This will be part of the next patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants