Add attachment rendering in PDF and HTML #716
Conversation
Add attachment getter in PDF export (exports.ts) Add parsing note md content to replace <img src='id'> with valid note id - id blob is replaced with object url link in PDF export - id blob is replaced with base64 encoding of the image Update downloadBlob to have cleanup callback (for revoking objectURLs in PDF export)
src/lib/download.ts
Outdated
| @@ -22,6 +30,9 @@ export function downloadBlob(blob: Blob, fileName: string) { | |||
| anchor.click() | |||
| window.URL.revokeObjectURL(anchor.href) | |||
| document.body.removeChild(anchor) | |||
| if (callback) { | |||
There was a problem hiding this comment.
This is unnecessary. There are no deferred statements.
src/lib/download.ts
Outdated
| @@ -22,6 +30,9 @@ export function downloadBlob(blob: Blob, fileName: string) { | |||
| anchor.click() | |||
There was a problem hiding this comment.
I think we should use download apis https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/downloads
There was a problem hiding this comment.
Or use writeFile method from electronOnly
There was a problem hiding this comment.
I didn't really write this method, but will need more time to investigate this downloads API, is this something we could use from electron API? Yes I see, for blob it don't matter since we could just write it to disk? Will update it later today.
There was a problem hiding this comment.
So I investigated this further. For download APIs - that's extensions? In this case electron supports some, but it seems a bit complicated setting that up, do you have any examples of this? did you try it?
As for writeFile, I could call something like this:
await writeFile(fileName, Buffer.from(await blob.arrayBuffer()))
similar thing is done for attachment writing. But this involves promises and a drawback that we are saving it with filename only - location should then be fetched from user somehow (folder where to save the item, as we have for storage location selection boxes).
This is currently done with ".click()" when user selects the location, in that location/filename the blob is saved/downloaded.
So can you inspect this one more time, and give me the specification, which method would be best, so we can change it?
There was a problem hiding this comment.
I guess we can merge this now. I'll investigate more later!
src/lib/exports.ts
Outdated
| @@ -189,10 +204,108 @@ const generatePrintToPdfHTML = ( | |||
| ` | |||
| } | |||
|
|
|||
| const blobToBase64 = async (blob: Blob) => { | |||
There was a problem hiding this comment.
I prefer to use conventional functions rather than arrow functions
function convertBlobToBase64(blob: Blob) {...}
There was a problem hiding this comment.
Oh I see, didn't know that. Updated
src/lib/exports.ts
Outdated
| }) | ||
| } | ||
|
|
||
| const updateNoteLinks = async ( |
Rokt33r
added
awaiting changes 🖊️
Update download blob to not have callback Use normal functions instead of arrow in exports.ts
Komediruzecki
added
awaiting review ❇️
Add attachment rendering in PDF and HTML
<img src='id'>with valid note image idHow it works:
Users can export the PDF and HTML and any image link attached to document which renders well in markdown preview should be exported inside downloaded PDF and HTML (see more details in commit description).
How it looks:
- md:
- result: PDF & HTML
Test:
Test invalid attachements exporting, error message, see below:
Error Handling:
If attachment cannot be found, it is skipped and error message is shown to the user. The exporting continues with all valid attachments.