Show Plain Text in Preview for Unrecognized Languages (#698) #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks perfect! Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #698.
Currently, we display invisible text when the language specified for the code block is not recognized.
This is because in
MarkdownPreviewer.tsx: rehypeCodeMirrorAttacher(), there is an edge case where if language is not null but there is no mime found for this language that can be found inCodeMirror.findModeByName, we setnode.childrento[].Fix this case by returning early before the
node.children = cmResultassignment.Tested with following languages after applying the change above:
java -> rendered with java highlighting
123f (made up language) -> rendered as plain text
(empty) -> rendered as plain text