Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown preview is not scrolling along with editor #247

Open
dwivedikunal100 opened this issue Dec 31, 2019 · 3 comments
Open

Markdown preview is not scrolling along with editor #247

dwivedikunal100 opened this issue Dec 31, 2019 · 3 comments
Assignees
Labels
help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! improvement request 🔨 Issue concerns an existing feature that needs improvement.

Comments

@dwivedikunal100
Copy link

Current behavior

Markdown preview is not scrolling along with editor

Expected behavior

The preview should scroll up or down along with the editor,to view section of the document currently being edited.

Steps to reproduce

  1. Run the app on Mac OS
  2. Write enough lines to make document have lines more than screen can display
  3. Scroll down to different section of the document

Environment

  • Version :0.1.2
  • OS Version and name :Mac OS,10.14.6
@Rokt33r
Copy link
Member

Rokt33r commented Jan 5, 2020

It is not implemented yet. Thanks for the reminding!

@Rokt33r Rokt33r added the improvement request 🔨 Issue concerns an existing feature that needs improvement. label Jan 5, 2020
@Rokt33r Rokt33r changed the title Markdown preview is not scrolling along with editor in Mac OS Markdown preview is not scrolling along with editor Feb 13, 2020
@Rokt33r Rokt33r added the help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! label Apr 26, 2020
@thien-do
Copy link

@Rokt33r I believe this requires each (top-level) elements in the generated HTML in preview has a data-line references back to its source. Do you think we have that with remarkjs yet?

I took a look at the legacy version and saw the token walk to add data-line, but could not find anything similar in the next version

@Rokt33r
Copy link
Member

Rokt33r commented Sep 1, 2020

@dvkndn We can access a node's actual position in raw text. I've been slowly working on it. rehypejs/rehype-react#22

@Rokt33r Rokt33r self-assigned this Sep 1, 2020
@kazup01 kazup01 added the hacktoberfest Contribute to the Boost Note and grab the swags! https://hacktoberfest.digitalocean.com/ label Oct 4, 2021
@kazup01 kazup01 removed the hacktoberfest Contribute to the Boost Note and grab the swags! https://hacktoberfest.digitalocean.com/ label Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! improvement request 🔨 Issue concerns an existing feature that needs improvement.
Projects
None yet
Development

No branches or pull requests

4 participants