Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log file generation #239

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Fix log file generation #239

merged 1 commit into from
Nov 14, 2023

Conversation

Borewit
Copy link
Owner

@Borewit Borewit commented Nov 13, 2023

Fix Log4j inclusion in jpackage-image, causing the log file not to be written

Resolves #238

@Borewit Borewit added the bug Something isn't working label Nov 13, 2023
@Borewit Borewit self-assigned this Nov 13, 2023
@github-actions GitHub Actions
Copy link

Build run (#6854934177, attempt #1) artifacts

@Borewit
Copy link
Owner Author

Borewit commented Nov 13, 2023 •
edited
Loading

@touwys, can you confirm that this build generates a logfile: %USERPROFILE%\.listFix()\logs\rollingfile.log?

@Borewit Borewit mentioned this pull request Nov 13, 2023
Merged
@touwys
Copy link

touwys commented Nov 14, 2023

@Borewit

listFix()-3.0.1.8 PR #239

Fixed.

%USERPROFILE%\.listFix()\logs\rollingfile.log

rollingfile.log

image

@Borewit Borewit merged commit f89efd2 into main Nov 14, 2023
4 checks passed
@Borewit Borewit deleted the fix-log4j-jpackageImage-inclusion branch November 17, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Borewit Borewit

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

listFix() distribution does not generate log file
2 participants
@Borewit @touwys