Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use straight file access instead of streams #7

Closed
Borewit opened this issue May 21, 2017 · 0 comments
Closed

Use straight file access instead of streams #7

Borewit opened this issue May 21, 2017 · 0 comments
Assignees

Comments

@Borewit
Copy link
Owner

Borewit commented May 21, 2017

Move away from the streaming approach and use straight file access; a stream is very inefficient in some cases (cannot jump (seek) to the end of the file, without reading everything in between).

Pros:

  • Better performance.
  • Opens the door for writing meta-data in addition to read meta-data.

Cons:

  • Would make this module less suitable for running in a browser.
@mainrs mainrs mentioned this issue May 21, 2017
9 tasks
@Borewit Borewit self-assigned this May 21, 2017
Borewit added a commit that referenced this issue May 21, 2017
Unit test: test-id3v2.3.js is working.
Borewit added a commit that referenced this issue Jun 26, 2017
Support for reading from files. (issue #7).
Handling M4A/iTunes tags (issue #13), still contains bugs.
@Borewit Borewit added this to the Promises, unit-testing-framework & direct file access milestone Jun 28, 2017
@Borewit Borewit closed this as completed Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant