Rewrite to use builder pattern. Fix dispatch unsafety. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix unsafety (require 'static bound on dispatched closure) - Switch to builder pattern. - Run rustfmt - Fix clippy warnings - Userdata borrowed from webview instead of being arg of dispatch closure - Bump minor version - Update webview - Add crate-level doc
green-s
force-pushed
the
rewrite
branch
3 times, most recently
from
2f0405b
to
4b53dc9
Compare
|
Looks nice, but could you implement the errors by hand instead of relying on |
|
Done, although no backtrace support. Not sure what's going on with that travis failure. Rustup bug or a bad cache I guess? |
|
Yeah not sure about the travis failure, seems to appear only on beta channel. Anyway thank you so much for your contribution it is nice that someone stepped up and implemented these very needed changes. I think the builder pattern will especially be useful and the error propagation is also nice. |
This was referenced Nov 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SIGSEGV when a sleep isn't done after a dispatch #15 Data in dispatch closure does not live long enough #25
Fixes Apply clippy suggestions #9