This repository has been archived by the owner on May 3, 2023. It is now read-only.
Switch to Bose/cache from Jim-Lambert-Bose/cache, catch more instances of covering up underlying errors with cache miss #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for GET, incorporate into DELETE
Ryan-Rose-Bose
requested review from
Peter-Tanski-Bose,
Arvind-Singh-Bose and
Alex-Grant-Bose
Peter-Tanski-Bose
approved these changes
Aug 5, 2020
|
@Peter-Tanski-Bose they may, but if anything it would be to improve error handling, as there aren't any interface changes! |
|
For this to properly work (for |
|
Sorry for the spam, but while talking to @Alex-Grant-Bose and realizing no one has access to Jim-Lambert-Bose/cache, we decided to fork Jim-Lambert-Bose/cache into BoseCorp/cache. I will update this PR switching to that repo as a dependency once it's set up properly. The new PR exists here: BoseCorp/cache#1 |
Ryan-Rose-Bose
changed the title
Ryan-Rose-Bose
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not thorough enough in my first PR 🙃
This further fixes instances where cache operation errors are being returned as
ErrCacheMisswhen they may be other underlying errors. This completes this fix for all entry types inGet, and also inDelete.