Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Join page for group #10

Closed
wants to merge 6 commits into from

Conversation

mmilkin
Copy link

@mmilkin mmilkin commented Jul 21, 2014

Adding Join action for a group.

Now with notifications

@mmilkin
Copy link
Author

mmilkin commented Aug 4, 2014

Added the beginning of the notification (this is now done through meetup, if we want to collect emails we could send emails ourselves. For now this is synchronous, not sure if we want to complexity of celery or async.

@nedbat
Copy link
Member

nedbat commented Aug 14, 2014

I didn't want to collect emails, it feels like a barrier to people participating, so notifying through Meetup is the right way to do it.

@mmilkin
Copy link
Author

mmilkin commented Aug 14, 2014

I agree, we could query meetup for emails using the api but that might be intrusive.

@nedbat
Copy link
Member

nedbat commented Aug 14, 2014

Well, meetup won't give out emails, there's no API to do that.

@mmilkin mmilkin closed this Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants