update script wiped .wine PREFIX

[kopfuss]

Confirmations

• I searched for similar bug reports in https://github.com/Botspot/pi-apps/issues and found none were relevant.
• I tried updating Pi-Apps and the issue is still not fixed. How to update Pi-Apps?
• IMPORTANT: I promise to respond to comments on this issue and write a good bug report https://www.softwaretestinghelp.com/how-to-write-good-bug-report/

What happened?

update script wiped .wine PREFIX

Description

Hello there

First off, thank you for this app. It's a convenient way of obtaining and possibly maintaining apps, and has a well rounded variety of software. Good job!

Okay this may be a duplicate of issue #44:

I had .wine installed and box86 on raspberrypi4 through your great Pi-Apps app. Everything installed smoothly and was running nicely and I built up a well picked assortment of Windows Games and Programs half a year ago. Then experienced heavy cpu usage 100% on 1/4 cores (max .wine) for even the slightest function after .. I don't know what actually. I considered updating .wine and box86, then did so through Pi-Apps. And the process was running, made a good impression at start, took a loong time but never really ended... finally it stalled; in a "somewhat finished" state (there was no "SUCCESSFUL!!!!!!"-end note). I let it sit for few hours. No change. I closed that window down and then finally got the message to "consider upgrading to bookworm. Everything may be somewhat wonky...".

Okay.

All my .wine-stuff startup.desktop files were grayed out. I inspected the .wine directory and found drive_c subdir was missing all my meticulously selected bunch of installs. Program Files directory had one subdir left: "fallout" but inside also was nothing there anymore.

Luckily my Excel'97.xls files were left untouched in ~/Docs/ ...and so too were my Photoshop CS2 works in ~/Pics/ ...but savegames, configs etc pp within .wine are all gone... I am sad.

Nevermind.

Just wanted to let you know. And maybe I can get some info on what I could have done or config'd better ?? Backups, I know. I will be ready to start over in a few weeks when the tears have dried.

Have a great day!

What are your system specs (run the following command in your terminal)?

~/pi-apps/api get_device_info
OS: Raspbian GNU/Linux 10 (buster)
OS architecture: 32-bit
Last updated Pi-Apps on: 12/25/2023
Latest Pi-Apps version: 01/03/2024
Kernel: armv7l 5.10.103-v7l+
Device model: Raspberry Pi 4 Model B Rev 1.1
SOC identifier: bcm2711
Cpu name: Cortex-A72
Ram size: 3.83 GB
Raspberry Pi OS image version: 2019-09-26
Language: en_US.UTF-8

(Recommended) Error log? Terminal output? Debug messages?

no have

[github-actions]

Hello there 👋
Thanks for submitting your first issue to the Pi-Apps project! We'll try to get back to you as soon as possible.
In the meantime, we encourage you join our Discord server, where you can ask any questions you might have.

Please respond as soon as possible if a Pi-Apps maintainer requests more information from you. Stale issues will be closed after a lengthy period of time with no response.

[theofficialgman]

Pi-Apps does not wipe user data intentionally.

You system is unsupported (Buster) so we will not provide support for it. Please consider installing the latest version of PiOS (Bookworm) so we can help you with any issues you may come across.

In the case of wine, if wine wineboot fails this is attributed to a bad wine prefix and the users prefix is removed

pi-apps/apps/Wine (x86)/install-32

Lines 327 to 339 in cb5cb4c

	if [ -e "\$HOME/.wine" ];then
	status "Checking Wine prefix at \$WINEPREFIX..."
	echo "To choose another prefix, set the WINEPREFIX variable."
	echo "Waiting 5 seconds..."
	sleep 5
	# check for existance of incompatible prefix (see server_init_process https://github.com/wine-mirror/wine/blob/884cff821481b4819f9bdba455217bd5a3f97744/dlls/ntdll/unix/server.c#L1544-L1670)
	# Boot wine and check for errors (make fresh wineprefix)
	output="\$(set -o pipefail; wine wineboot 2>&1 | tee /dev/stderr; )" #this won't display any dialog boxes that require a button to be clicked
	if [ "\$?" != 0 ]; then
	warning "Your previously existing Wine prefix failed with an error (see above). It has been removed and will be re-generated."
	rm -rf "\$HOME/.wine"
	wine wineboot #this won't display any dialog boxes that require a button to be clicked
	fi

tagging @Botspot , maybe it would be best to wait for user input before deleting the wine prefix and instead allow the user to cancel out of the script entirely (eg: if they believe a box64/box86 bug causes wine wineboot to fail and not a bad prefix)

[kopfuss]

Thank you for your reply @theofficialgman.

I'd consider a distinct warning and wait for user input more than adequate in case the script detects an "incompatible prefix".

Also, the check for and note on "upgrading to bookworm, otherwise wonky" may be better placed earlier in the process (before anything got removed).