Allow Int based Characteristic values to be initialised by Float or Double #105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An interesting bug came up recently, when initialising a
colourTemperature
characteristic, where the default value in the factory method inGenerated.swift
was outside the max and min range specified in my init call. The value of the characteristic is anInt
type, but the min and max values inGenerated
are stored asDouble
. Creating the characteristic with that new range resulted in a crash, as the double max an min values could not be converted toInt
This patch adds the ability to create an
Int
characteristic from aDouble
orFloat
.