Replace Libsodium with SwiftCrypto #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Bouke
force-pushed
the
swift-crypto-fork
branch
3 times, most recently
from
17f5756
to
a1adb7e
Compare
Bouke
force-pushed
the
swift-crypto-fork
branch
4 times, most recently
from
8d48099
to
df848f0
Compare
Thanks to Guy Brooker<guy.brooker@me.com> for providing the correct CryptoKit API usage.
Bouke
force-pushed
the
swift-crypto-fork
branch
from
df848f0
to
3cee153
Compare
|
SonarCloud Quality Gate failed.
|
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress. Idea is to drop Libsodium completely as a dependency. I find the API documentation hard to work with, it doesn't specify what primitives it uses and leaves a lot of guess work when implementing. Using the CryptoKit API, we can remove various low-level C calls.
Regarding compatibility with older macOS / iOS, we can fork swift-crypto to support that / force it to always use BoringSSL.