Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated from macOS 10.14.4b3 #78

Closed
wants to merge 2 commits into from

Conversation

gbrooker
Copy link
Contributor

Update to the Generated HAP structures from 10.14.4 beta 3. This has changes required to support the new Television accessory type supported by iOS 12.2

@gbrooker
Copy link
Contributor Author

gbrooker commented Feb 26, 2019

In the latest beta the currentVisibilityState characteristic has a range of 0 to 3. I've added a couple of enumerations to the Generated.swift and to the Inspector which creates it to permit them to be used.

I have also added the correct characteristic settings required to get a Television accessory recognised by iOS 12.2b3.

public enum CurrentVisibilityState: UInt8, CharacteristicValueType {
case shown = 0
case hidden = 1
case state2 = 2
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you add these by hand?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation is off and uses spaces (however I would rather use spaces throughout).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did add these two lines manually to Generated.swift for simplicity, but I also added the change to Inspector.swift so the same result would be generated in this way automatically next time.

@Bouke
Copy link
Owner

Bouke commented Feb 26, 2019

Overall looks good to me. I guess it's hard to say whether the current TV Accessory configuration is finalized by Apple?

@gbrooker
Copy link
Contributor Author

I think there is at least another beta due soon, as there seem to be a few bugs in the current remote interface. No changes to the HAP definitions between iOS 12.2 beta 2 and beta 3. I'll keep this PR updated until 12.2 final is released, and then we can merge it into the master.

@gbrooker
Copy link
Contributor Author

Replaced by PR #82

@gbrooker gbrooker closed this Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants