Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated swift-tools-version to remove generate-xcodeproj warning #7

Closed
wants to merge 1 commit into from
Closed

Updated swift-tools-version to remove generate-xcodeproj warning #7

wants to merge 1 commit into from

Conversation

blanu
Copy link

@blanu blanu commented Oct 29, 2018

"swift package generate-xcodeproj" produces a warning because of the swift-tools-version setting.
(Xcode 10)

@oliveroneill
Copy link
Collaborator

The CI is failing because we need to update it to the xcode10 image. I'll look into that now.

@oliveroneill
Copy link
Collaborator

I've updated travis to Xcode 10 and now only the Code Quality check is failing. I'm not familiar with sonar-scanner. @Bouke is this expected? I don't believe this is caused by the swift-tools upgrade.

@Bouke
Copy link
Owner

Bouke commented Nov 1, 2018

Hi @blanu, thanks for reaching out to me. I've tried to reproduce the issue that you're describing, however I might need some help:

$ which swift
/usr/bin/swift
$ swift --version
Apple Swift version 4.2 (swiftlang-1000.11.37.1 clang-1000.11.45.1)
Target: x86_64-apple-darwin18.0.0
$ swift package generate-xcodeproj
generated: ./INI.xcodeproj

@Bouke
Copy link
Owner

Bouke commented Nov 1, 2018

Did you verify the warnings against the master branch as well? That has some changes to resolve the error you might be getting. I've pushed version 1.1.0, including these commits. That should resolve any problems I think.

@blanu
Copy link
Author

blanu commented Nov 1, 2018

This warning appeared when generating an Xcode project for a package which includes the INI package as a dependency.

The 1.1.0 release seems to have eliminated the warning. Thanks!

@blanu blanu closed this Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants