-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to swagger docs #227
Conversation
Looks like CircleCI failed because of something unrelated to this PR. I'll look into that. |
bounties_api/std_bounties/urls.py
Outdated
@@ -15,6 +15,7 @@ | |||
urlpatterns = [ | |||
url(r'^leaderboard/issuer/$', views.LeaderboardIssuer.as_view()), | |||
url(r'^leaderboard/fulfiller/$', views.LeaderboardFulfiller.as_view()), | |||
url(r'^fulfiller/(?P<address>\d+)', views.UserProfile.as_view()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamonuwa why are you adding a url here? UserProfile already exists as an endpoint. It is in the User app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to add this extra endpoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will check again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@villanuevawill I'll remove this as method from bounties views?
Got scared. CircleCI has never failed me. |
@iamonuwa is this in prog? |
Yes, @villanuevawill almost done resolving the comments. Changed my PC on Saturday. Had to setup everything completely today |
@villanuevawill please review |
@iamonuwa this misses the mark pretty far of what was asked for and you didn't respond to the requests. I'm going to close this task out. |
@villanuevawill please review
Fixes #222