Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to swagger docs #227

Closed
wants to merge 2 commits into from

Conversation

iamonuwa
Copy link

@villanuevawill please review

Fixes #222

@codeluggage
Copy link
Contributor

Looks like CircleCI failed because of something unrelated to this PR. I'll look into that.

@@ -15,6 +15,7 @@
urlpatterns = [
url(r'^leaderboard/issuer/$', views.LeaderboardIssuer.as_view()),
url(r'^leaderboard/fulfiller/$', views.LeaderboardFulfiller.as_view()),
url(r'^fulfiller/(?P<address>\d+)', views.UserProfile.as_view()),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamonuwa why are you adding a url here? UserProfile already exists as an endpoint. It is in the User app.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add this extra endpoint.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will check again.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@villanuevawill I'll remove this as method from bounties views?

@iamonuwa
Copy link
Author

Looks like CircleCI failed because of something unrelated to this PR. I'll look into that.

Got scared. CircleCI has never failed me.

@villanuevawill
Copy link
Collaborator

@iamonuwa is this in prog?

@iamonuwa
Copy link
Author

Yes, @villanuevawill almost done resolving the comments. Changed my PC on Saturday. Had to setup everything completely today

@iamonuwa
Copy link
Author

@villanuevawill please review

@iamonuwa iamonuwa changed the title [WIP] Add UserProfile endpoint to swagger docs Update to swagger docs Oct 16, 2018
@villanuevawill
Copy link
Collaborator

@iamonuwa this misses the mark pretty far of what was asked for and you didn't respond to the requests. I'm going to close this task out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants