Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflow): 🐛 fixed release common workflow #476

Merged
merged 5 commits into from
May 15, 2023
Merged

Conversation

WasiqB
Copy link
Member

@WasiqB WasiqB commented May 15, 2023

Closes: #472

Type of changes?

  • Bug fixes: Non-breaking change which fixes an issue
  • New feature: Non-breaking change which adds a new feature
  • Performance improvement: Non-breaking change which improves performance
  • Documentation: Non-breaking change which improves documentation
  • Other: Non-breaking change which does not fit into the above categories
  • Breaking change: A breaking change which requires a new version of the library

Checklist for Java project

  • Change not related to Java project

Following checklists are optional if above checkbox is selected:

  • Copyright banner comment added to newly added files, except `.md`, `.yml`, `*.json`?
  • Proper JavaDoc updated in main and test classes for all public classes and methods?
  • Tests added for changes?
  • Tests are passing locally?
  • Check style checks are passing locally?
  • Test coverage is at least 80% for newly added changes?
  • There are no SonarCloud issues?
  • README updated? (if applicable)
  • Documentation website updated for the PR raised?

Checklist for Website

  • Change not related to Website project

Following is optional if above checkbox is selected:

  • Lint check passes locally?
  • Prettier check passes locally?
  • Build command working fine locally?

Reviewers

@BoykaFramework/boyka-core

IMPORTANT: Make sure to check the `Allow edits from maintainers` box below this window

@github-actions github-actions bot added the 🐛 pr: bug fix PR which fixes a bug label May 15, 2023
@WasiqB WasiqB self-assigned this May 15, 2023
@WasiqB WasiqB linked an issue May 15, 2023 that may be closed by this pull request
3 tasks
@ghost
Copy link

ghost commented May 15, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@sonarcloud
Copy link

sonarcloud bot commented May 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@WasiqB WasiqB marked this pull request as ready for review May 15, 2023 08:30
@WasiqB WasiqB requested a review from a team as a code owner May 15, 2023 08:30
@WasiqB WasiqB requested a review from mfaisalkhatri May 15, 2023 08:30
@WasiqB WasiqB merged commit 6c86a32 into develop May 15, 2023
@WasiqB WasiqB deleted the issue-472 branch May 15, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 pr: bug fix PR which fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 New Bug: Issue in reusable workflow with secret variables
1 participant