Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(java): 🔥 moved sample test project to its own repo #718

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

WasiqB
Copy link
Member

@WasiqB WasiqB commented Dec 19, 2023

Closes: #717

Type of changes?

  • Bug fixes: Non-breaking change which fixes an issue
  • New feature: Non-breaking change which adds a new feature
  • Performance improvement: Non-breaking change which improves performance
  • Documentation: Non-breaking change which improves documentation
  • Other: Non-breaking change which does not fit into the above categories
  • Breaking change: A breaking change which requires a new version of the library

Checklist for Java project

  • Change not related to Java project

Following checklists are optional if above checkbox is selected:

  • Copyright banner comment added to newly added files, except *.md, *.yml, *.json?
  • Proper JavaDoc updated in main and test classes for all public classes and methods?
  • Tests added for changes?
  • Tests are passing locally?
  • Check style checks are passing locally?
  • Test coverage is at least 80% for newly added changes?
  • There are no SonarCloud issues?
  • README updated? (if applicable)
  • Documentation website updated for the PR raised?

Checklist for Website

  • Change not related to Website project

Following is optional if above checkbox is selected:

  • Lint check passes locally?
  • Prettier check passes locally?
  • Build command working fine locally?

Reviewers

@BoykaFramework/boyka-core

IMPORTANT: Make sure to check the Allow edits from maintainers box below this window

@WasiqB WasiqB self-assigned this Dec 19, 2023
@github-actions github-actions bot added the 💅 pr: polish PR which refactors the code label Dec 19, 2023
@ghost
Copy link

ghost commented Dec 19, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@WasiqB WasiqB marked this pull request as ready for review December 19, 2023 16:34
@WasiqB WasiqB requested a review from a team as a code owner December 19, 2023 16:34
@WasiqB WasiqB merged commit 0a657d1 into main Dec 19, 2023
9 checks passed
@WasiqB WasiqB deleted the issue-717 branch December 19, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💅 pr: polish PR which refactors the code
Projects
Development

Successfully merging this pull request may close these issues.

Move sample boyka project to its own repository
1 participant