Cherry-picked changes made to assembly.py
#253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whereamong: - Formatting - `get_transformations_pdb` is now a generator function and can handle (positive) floats >= 10.0 - Renamed `input` and `type` to avoid name collisions
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
==========================================
+ Coverage 53.73% 56.25% +2.51%
==========================================
Files 15 15
Lines 1952 1943 -9
==========================================
+ Hits 1049 1093 +44
+ Misses 903 850 -53
☔ View full report in Codecov by Sentry. |
|
Apologies for delay in getting around to this. I wanted to write a quick test to at least start covering assemblies before merging. Looks good though will merge once tests pass. |
BradyAJohnston
added a commit
that referenced
this pull request
Sep 14, 2023
Cherry-picked changes made to `assembly.py`
BradyAJohnston
added a commit
that referenced
this pull request
Sep 14, 2023
Cherry-picked changes made to `assembly.py`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whereamong:
get_transformations_pdbis now a generator function and can handle (positive) floats >= 10.0inputandtypeto avoid name collisions