Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude failing macOS test on Node.js v18 #917

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Exclude failing macOS test on Node.js v18 #917

merged 1 commit into from
Dec 6, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 6, 2023 •
edited
Loading

Follow up to:

Description

Motivation and Context

issue

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Author's Checklist:

  • My code focuses on the main motivation and avoids scope creep.
  • My code passes current tests and adds new tests where possible.
  • My code is SOLID and DRY.
  • I have updated the documentation as needed.

Reviewer's Checklist:

  • I kept my comments to the author positive, specific, and productive.
  • I tested the code and didn't find any new problems.
  • I think the motivation is good for the project.
  • I think the code works to satisfies the motivation.

@robertleeplummerjr

@robertleeplummerjr robertleeplummerjr merged commit b57f8dc into BrainJS:master Dec 6, 2023
6 of 7 checks passed
@cclauss cclauss deleted the patch-1 branch December 6, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @robertleeplummerjr