Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #618

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Dev #618

merged 4 commits into from
Sep 26, 2023

Conversation

ThisMatt
Copy link
Collaborator

Description

The "data" attribute of a SkyscrapersCell was interpreted as both the type of cell and number contained within the cell in different places, leading to various bugs. This request clarifies it as the latter, an integer, and updates usage to match.

Closes #579

Type of change

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Solved the 4x4 easy 1 puzzle with no issue.

image

Checklist:

  • [X ] I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • [ X] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Collaborator

@Chase-Grajeda Chase-Grajeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolves #579 . Passes tests

@Chase-Grajeda Chase-Grajeda merged commit 12eb296 into Bram-Hub:dev Sep 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants