Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Event by Id and Tournament/Event Name into Inherited classes #10

Closed
BrandonCookeDev opened this issue Apr 14, 2018 · 1 comment
Closed

Split Event by Id and Tournament/Event Name into Inherited classes #10

BrandonCookeDev opened this issue Apr 14, 2018 · 1 comment
Assignees
@BrandonCookeDev
Labels
enhancement New feature or request
Milestone
2.0

Comments

@BrandonCookeDev
Copy link
Owner

Currently the Event object takes situational parameters and then deterministically pulls Event data (ie event id is optional or tournament name is optional if id exists).

However, these should be more cut and dry. We should have two new Objects that extend to Event

  • EventById
  • EventByNames

Both of these will extend to the Event superclass and share the same general logic/getters.
@BrandonCookeDev BrandonCookeDev added this to the 2.0 milestone Apr 14, 2018
@BrandonCookeDev BrandonCookeDev self-assigned this Apr 14, 2018
@BrandonCookeDev BrandonCookeDev added the enhancement New feature or request label Apr 14, 2018
BrandonCookeDev added a commit that referenced this issue Apr 14, 2018
@BrandonCookeDev
#10 split Event into three objects, taking a url, tournament and even…
2bc31e3 
…t names, or an event id. Added tests and documentation
@BrandonCookeDev
Copy link
Owner Author

BrandonCookeDev commented Apr 14, 2018 •
edited
Loading

Fixed by 2bc31e3

@BrandonCookeDev BrandonCookeDev mentioned this issue Apr 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrandonCookeDev BrandonCookeDev

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@BrandonCookeDev