Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breeze.directives: improved z-append-to handling of ng-repeat #30

Open
mcshaz opened this issue Sep 16, 2016 · 0 comments
Open

breeze.directives: improved z-append-to handling of ng-repeat #30

mcshaz opened this issue Sep 16, 2016 · 0 comments

Comments

@mcshaz
Copy link
Contributor

mcshaz commented Sep 16, 2016 •
edited
Loading

When using bootstrap input groups, the z-append-to allows a query selector to identify an element to append the z-decorator to.

However, within an ng-repeat it is a pain to generate unique ids to append to. The accompanying pull request will append to an element in exactly the same way if a single DOM element matches the querySelector, but if more than one element matches, it will find the first matching ancestor of the input/tetxarea/select element being validated. In this way the z-append-to directive now works with class and element selectors.
mcshaz added a commit to mcshaz/breeze.js.labs that referenced this issue Sep 16, 2016
@mcshaz
directive append-to on ancestor
54d50b9 
addresses issue Breeze#30
- requires Array.prototype.some & Function.prototype.find, so these
might need a polyfill in older browsers.
- tagName is assumed to be upper case - this may require a toUpperCase()
in xhtml documents
@mcshaz mcshaz mentioned this issue Sep 16, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mcshaz