[CPP] API sketch #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analogrelay
reviewed
Jun 29, 2018
|
|
||
| private: | ||
| template <typename T> | ||
| void invoke_with_args(const std::function<void(T)>& func, const std::tuple<T>& args) |
There was a problem hiding this comment.
Is there (or could there be) any way for a user to add one of these if they really want to add an invocation that takes more than 7 args?
analogrelay
reviewed
Jun 29, 2018
| @@ -0,0 +1,140 @@ | |||
| #include "json_hub_protocol.h" | |||
|
|
|||
| namespace signalR | |||
There was a problem hiding this comment.
this should probably be in a subnamespace. signalR::converters or something
analogrelay
reviewed
Jun 29, 2018
| { | ||
| public: | ||
| template <typename ...T> | ||
| std::tuple<T...> parse_message(const std::string& data) const |
There was a problem hiding this comment.
This is obviously going to need some work still. We need to return parsed versions of all the messages, support non-text protocols via some kind of byte buffer input, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.