fix(coverage): increase coverage and fix small edge bugs (#52)

Increase coverage to 85+%, while fixing small bugs on some edge cases

Author: adrienharnay

__tests__/internals/network/__snapshots__/getDefaultNetworkHelpers.test.js.snap

@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`getDefaultNetworkHelpers only path 1`] = `
+exports[`getDefaultNetworkHelpers all default 1`] = `
 Object {
   "getToken": [Function],
   "handleError": [Function],
@@ -13,7 +13,20 @@ Object {
 }
 `;
 
-exports[`requestDELETE only path 1`] = `
+exports[`getDefaultNetworkHelpers custom getToken 1`] = `
+Object {
+  "getToken": [Function],
+  "handleError": [Function],
+  "handleStatusCode": [Function],
+  "requestDELETE": [Function],
+  "requestGET": [Function],
+  "requestPATCH": [Function],
+  "requestPOST": [Function],
+  "requestPUT": [Function],
+}
+`;
+
+exports[`requestDELETE all default 1`] = `
 Object {
   "headers": Object {
     "Accept": "application/json",
@@ -23,7 +36,16 @@ Object {
 }
 `;
 
-exports[`requestGET only path 1`] = `
+exports[`requestDELETE custom getToken 1`] = `
+Object {
+  "headers": Object {
+    "Accept": "application/json",
+  },
+  "method": "DELETE",
+}
+`;
+
+exports[`requestGET all default 1`] = `
 Object {
   "headers": Object {
     "Accept": "application/json",
@@ -33,7 +55,16 @@ Object {
 }
 `;
 
-exports[`requestPATCH only path 1`] = `
+exports[`requestGET custom getToken 1`] = `
+Object {
+  "headers": Object {
+    "Accept": "application/json",
+  },
+  "method": "GET",
+}
+`;
+
+exports[`requestPATCH all default 1`] = `
 Object {
   "body": undefined,
   "headers": Object {
@@ -45,7 +76,18 @@ Object {
 }
 `;
 
-exports[`requestPOST only path 1`] = `
+exports[`requestPATCH custom getToken 1`] = `
+Object {
+  "body": undefined,
+  "headers": Object {
+    "Accept": "application/json",
+    "Content-Type": "application/json",
+  },
+  "method": "PATCH",
+}
+`;
+
+exports[`requestPOST all default 1`] = `
 Object {
   "body": undefined,
   "headers": Object {
@@ -57,7 +99,18 @@ Object {
 }
 `;
 
-exports[`requestPUT only path 1`] = `
+exports[`requestPOST custom getToken 1`] = `
+Object {
+  "body": undefined,
+  "headers": Object {
+    "Accept": "application/json",
+    "Content-Type": "application/json",
+  },
+  "method": "POST",
+}
+`;
+
+exports[`requestPUT all default 1`] = `
 Object {
   "body": undefined,
   "headers": Object {
@@ -68,3 +121,14 @@ Object {
   "method": "PUT",
 }
 `;
+
+exports[`requestPUT custom getToken 1`] = `
+Object {
+  "body": undefined,
+  "headers": Object {
+    "Accept": "application/json",
+    "Content-Type": "application/json",
+  },
+  "method": "PUT",
+}
+`;

__tests__/internals/network/getDefaultNetworkHelpers.test.js

@@ -1,57 +1,93 @@
+import fetchMock from 'fetch-mock';
+
 import getDefaultNetworkHelpers from '../../../src/internals/network/getDefaultNetworkHelpers';
 
 const NETWORK_HELPERS = getDefaultNetworkHelpers();
+const customGetTokenNetworkHelpers = {
+  ...NETWORK_HELPERS,
+  getToken: () => '',
+};
 
 describe('getDefaultNetworkHelpers', () => {
-  test('only path', () => {
+  test('all default', () => {
     expect(NETWORK_HELPERS).toMatchSnapshot();
   });
+
+  test('custom getToken', () => {
+    expect(customGetTokenNetworkHelpers).toMatchSnapshot();
+  });
 });
 
 describe('requestGET', () => {
-  test('only path', async () => {
+  test('all default', async () => {
     expect(await NETWORK_HELPERS.requestGET()).toMatchSnapshot();
   });
+
+  test('custom getToken', async () => {
+    expect(await customGetTokenNetworkHelpers.requestGET()).toMatchSnapshot();
+  });
 });
 
 describe('requestPATCH', () => {
-  test('only path', async () => {
+  test('all default', async () => {
     expect(await NETWORK_HELPERS.requestPATCH()).toMatchSnapshot();
   });
+
+  test('custom getToken', async () => {
+    expect(await customGetTokenNetworkHelpers.requestPATCH()).toMatchSnapshot();
+  });
 });
 
 describe('requestPUT', () => {
-  test('only path', async () => {
+  test('all default', async () => {
     expect(await NETWORK_HELPERS.requestPUT()).toMatchSnapshot();
   });
+
+  test('custom getToken', async () => {
+    expect(await customGetTokenNetworkHelpers.requestPUT()).toMatchSnapshot();
+  });
 });
 
 describe('requestPOST', () => {
-  test('only path', async () => {
+  test('all default', async () => {
     expect(await NETWORK_HELPERS.requestPOST()).toMatchSnapshot();
   });
+
+  test('custom getToken', async () => {
+    expect(await customGetTokenNetworkHelpers.requestPOST()).toMatchSnapshot();
+  });
 });
 
 describe('requestDELETE', () => {
-  test('only path', async () => {
+  test('all default', async () => {
     expect(await NETWORK_HELPERS.requestDELETE()).toMatchSnapshot();
   });
+
+  test('custom getToken', async () => {
+    expect(
+      await customGetTokenNetworkHelpers.requestDELETE(),
+    ).toMatchSnapshot();
+  });
 });
 
 describe('handleStatusCode', () => {
-  test('valid response', () => {
-    const response = { status: 200 };
-    const response2 = { status: 299 };
-
-    expect(NETWORK_HELPERS.handleStatusCode(response)).toBe(response);
-    expect(NETWORK_HELPERS.handleStatusCode(response2)).toBe(response2);
+  test('no response', () => {
+    expect(NETWORK_HELPERS.handleStatusCode(null)).toBeNull();
   });
 
   test('invalid response', () => {
     const response = { status: 300 };
 
     expect(() => NETWORK_HELPERS.handleStatusCode(response)).toThrow();
   });
+
+  test('valid response', () => {
+    const response = { status: 200 };
+    const response2 = { status: 299 };
+
+    expect(NETWORK_HELPERS.handleStatusCode(response)).toBe(response);
+    expect(NETWORK_HELPERS.handleStatusCode(response2)).toBe(response2);
+  });
 });
 
 describe('handleError', () => {
@@ -77,4 +113,31 @@ describe('handleError', () => {
 
     expect(consoleErrorMock).toHaveBeenCalledTimes(1);
   });
+
+  test('wrongly formatted error 2', async () => {
+    const error = { response: 'oh no' };
+
+    await NETWORK_HELPERS.handleError(error);
+
+    expect(consoleErrorMock).toHaveBeenCalledTimes(1);
+  });
+
+  test('valid error', async () => {
+    fetchMock.mock('error', {
+      status: 400,
+      body: {
+        message: 'errorMessage',
+      },
+    });
+
+    const res1 = await fetch('error');
+    const error = new Error(res1.statusText);
+    error.response = res1;
+
+    fetchMock.restore();
+
+    await NETWORK_HELPERS.handleError(error);
+
+    expect(consoleErrorMock).toHaveBeenCalledTimes(1);
+  });
 });