-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up test folder #78
Comments
…nfig fields inside, rearranged fields so they match ordering in docs and config creator GUI, regenerated test_data config files so match new format; fixed #78: standardized test_data CVR and config file names.
Re-opening because it seems like tests added since this was completed don't follow these standards. In particular, should address:
|
Yes, we do have a number of duplicate CVR files in the test data. If we wanted to avoid that, we would need to create an exception to the naming scheme, I guess. Also, 2013_minneapolis_mayor_scale has 13 copies of the same file because we don't allow a config to list the same source file multiple times. I agree it's dumb to have duplicate files in the repo, though. Feel free to address these issues in a way that you think is reasonable. |
It's not worth it to come up with a scheme to exclude a mere 25MB of test files. If we make a distro which includes test files, we should include them all. |
Began the process of distinguishing between "test" and "sample" input files in PR #316. Verified that, in that PR, only the |
It would be nice to standardize the file names and clean up the test folder. I like the format date-location-office. Maybe we could consistently prepend cvr_* and config_* to those.
There also might be some test files in there that aren't needed anymore or, if they are, could also have more consistent names (e.g. "minimum-threshold-test-cvr.xlsx", "test_continue_tabulation_config.json", etc.).
The text was updated successfully, but these errors were encountered: