fix two bugs related to undeclared write-ins #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HEdingfield
reviewed
Sep 11, 2019
Yeah, good call. I don't have time to add them at the moment, but will do it soon. |
|
@tarheel request on this, and for future PRs: could you please make sure to file issues for each bug (in this case, file two issues and then mark them as resolved immediately by this PR)? It'll make it a lot easier to write the release notes / change log for the next version. I think we need to be more rigorous about this now that we've gone official. Could you also please submit an issue for anything you defer in a PR, like adding tests? |
|
Yes, will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #397 and #398.
Bug 1 (#397): in a multi-seat contest, if someone wins in the first round, we don't automatically eliminate undeclared write-ins before we eliminate any other candidates. Instead, we treat UWI like a normal candidate, which means we potentially eliminate other candidates with lower tallies first.
Bug 2 (#398): if UWI exceeds the winning threshold in the initial count, we mistakenly elect this candidate.