read Dominion manifest data and CVR json: #406 #407 #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HEdingfield
requested changes
Feb 29, 2020
HEdingfield
approved these changes
Mar 1, 2020
There was a problem hiding this comment.
Nice work! Just a couple last changes.
Re: #414, I'm happy to take care of it. You might want to double-check that you have "Update copyright" checked in your commit box in IntelliJ (all the boxes in that column should be checked).
This was referenced Mar 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing too tricky here, just digging through json and linking a couple fields together from manifest data. I'll revert the changes in Main.java, that's just for an example of how you would use this class from the command line. Please do me a solid and don't get overly nit-picky. I'm trying to crank through these tickets over the next week before I'm traveling 3/7-3/21. Thanks!