Migrate tabs vdiff #4105
Merged
Migrate tabs vdiff #4105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
|
dlockhart
force-pushed
the
dlockhart/vdiff-tabs
branch
from
5629210
to
309c648
Compare
Co-authored-by: github-actions <github-actions@github.com>
svanherk
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since tabs do a similar scroll/overflow/chomp thing as overflow-group, migrating their vdiffs involved implementing
getLoadingComplete()and resolving it after that calculation had been done.Beyond that, not expecting much except for a few focus/hover artifacts now that we're actually clicking/focusing.