Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a central test eslint config #4262

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

dlockhart
Copy link
Member

Been meaning to do this for a while. This switches to defining the eslint config for tests at the root of the project, instead of needing to copy it into every test directory.

This change actually found a misconfiguration as the async-container test config was incorrect.

@dlockhart dlockhart requested a review from a team as a code owner November 16, 2023 22:12
Copy link
Contributor

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://live.d2l.dev/prs/BrightspaceUI/core/pr-4262/

Note
The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

Copy link
Contributor

@bearfriend bearfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dlockhart dlockhart enabled auto-merge (squash) November 16, 2023 22:19
@dlockhart dlockhart merged commit c6f404b into main Nov 16, 2023
6 checks passed
@dlockhart dlockhart deleted the dlockhart/central-test-lint-config branch November 16, 2023 22:19
Copy link

🎉 This PR is included in version 2.161.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants