Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color JSON properties blue #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Color JSON properties blue #14

wants to merge 1 commit into from

Conversation

MoritzKn
Copy link

Before After
image image

@Briles
Copy link
Owner

Briles commented Jan 20, 2018

I like this change! It'd be best if we can maintain the punctuation color, though.

@MoritzKn
Copy link
Author

Does this mean I should change the color to @foreground or what would be the concrete change? Sorry, I do not have much experience with syntax themes.

@MoritzKn
Copy link
Author

@Briles Could you take a look at this again?

@idoo
Copy link

idoo commented Aug 8, 2018

@Briles I hope you're good, do you have a chance to take a look to this MR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MoritzKn @Briles @idoo