feat: increase minimum versions of terraform and provider #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While mentally it scares me a bit to be using authoritative, the more I think about it, the more it seems like it shouldn't be a problem for terraform-managed projects. It doesn't change properties on roles that aren't referenced in the TF config, and it shouldn't remove permissions granted due to hierarchy permissions. In other words, I'd say this is a 👍 |
broestls
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
projects_iam- address Use terraform-google-iam #2 - This requires the mode to be changed toauthoritative. See this. @broestls Do you see any issues with authoritative mode?