Updates module with latest ruby and terraform support. Provider updat… #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es hampered by permissions questions that may or may not be resolved before launch date
mirestrepo
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
This is great.
There are few other updates that could be made to the GitHub actions.
- Use the docker official actions to handle build and push as done in most other modules
- Update the action versions in the realse drafter and pr-labeler flows.
Do you want to merge this and make new issues for those? Or do you want to push them here?
Chore: Use official github actions for building docker images
digicosmos86
approved these changes
Jul 20, 2023
|
Hi @broestls! Do you think we are ready to merge this? |
|
@digicosmos86 Absolutely! LGTM. |
Thanks @broestls! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…es hampered by permissions questions that may or may not be resolved before launch date