Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcemap support? #1699

Open
jaredly opened this issue Jun 9, 2017 · 12 comments

Comments

@jaredly
Copy link
Contributor

commented Jun 9, 2017

I'd be interested in contributing sourcemap support, if you can give me some pointers in the right direction.

@bobzhang

This comment has been minimized.

Copy link
Member

commented Jun 12, 2017

what do you think of working in this direction: #151

@jaredly

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2017

That would also be a useful tool, but I think it's an entirely separate feature?

@jaredly

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2017

I've used sourcemaps in clojurescript (which is quite a different language), and they're super useful

@lightsofapollo

This comment has been minimized.

Copy link

commented Jun 14, 2017

My 2c- when trying to convince my past teams and companies to use some X compile-to-js technology it was very, very difficult to win this argument without sourcemap support (particularly when doing some interop /w another JS only source)

@alcarvalho

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2017

I had my boss demoing for me how clojurescript could be debugged from the browser, how you could use the REPL to connect to it and write clojurescript to inspect and change values on the fly.

IMHO having source maps is the very first step in the direction of having something that's easily hackable like clojurescript.

@vahuja13

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2017

We've started showing integrations of bucklescript in js stacks at Bloomberg and source-maps is a recurring question.

@bobzhang

This comment has been minimized.

Copy link
Member

commented Aug 16, 2017

hi @vahuja13 , it is great to hear your progress, can you share with more a bit more about detail, or you can find me on discord and chat offline, thanks!

@dvisztempacct

This comment has been minimized.

Copy link

commented Jul 22, 2018

Any movement on this? @jaredly asked for some direction but I don't see any (at least in this thread.)

@hhugo

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2018

You can have a look at the sourcemap implementation in js_of_ocaml
here https://github.com/ocsigen/js_of_ocaml/blob/master/compiler/lib/source_map_yojson.ml.in

@aaronshaf

This comment has been minimized.

Copy link

commented Nov 30, 2018

Would be nice for test coverage

@dawee

This comment has been minimized.

Copy link

commented Feb 19, 2019

Would also be cool for tracking errors using sentry.

@texastoland

This comment has been minimized.

Copy link

commented May 17, 2019

Regardless whether it's useful for debugging, it's necessary for runtime tooling support like Quokka and blocking wallabyjs/quokka#153. @jaredly Did you already have a work how much work would be required? Has anyone attempted it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.