Skip to content

[SuperErrors] Check arity mismatch for uncurried [@bs] application. #2471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2018
Merged

[SuperErrors] Check arity mismatch for uncurried [@bs] application. #2471

merged 2 commits into from
Jan 30, 2018

Conversation

cristianoc
Copy link
Collaborator

The following repro:

/lib/bsc.exe -bs-super-errors -bs-eval 'let add = ((fun x  -> fun y  -> x + y)[@bs ]) let x = ((add 3)[@bs ])'

Now gives:

Found uncurried application [@bs] with arity 2, where arity 1 was expected.
This has type:
  (int -> int -> int [@bs]) (defined as (int -> int -> int [@bs]))
But somewhere wanted:
  ('a -> 'b [@bs]) (defined as ('a -> 'b [@bs]))
These two variant types have no intersection

[SuperErrors] Check arity mismatch for uncurried [@bs] application.
162e918 
The following repro:
```
/lib/bsc.exe -bs-super-errors -bs-eval 'let add = ((fun x  -> fun y  -> x + y)[@bs ]) let x = ((add 3)[@bs ])'
```
Now gives:
```
Found uncurried application [@bs] with arity 2, where arity 1 was expected.
This has type:
  (int -> int -> int [@bs]) (defined as (int -> int -> int [@bs]))
But somewhere wanted:
  ('a -> 'b [@bs]) (defined as ('a -> 'b [@bs]))
These two variant types have no intersection
```
bobzhang
bobzhang reviewed Jan 30, 2018
View reviewed changes
Copy link
Member

@bobzhang bobzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great, except my minor comments, feel free to merge it once addressed

jscomp/super_errors/super_typecore.ml Outdated
let arity t = match t.desc with
| Tvariant { row_fields = [(label,_)] } ->
let len = String.length label in
if len > 6 &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could the magic number 6 be less magic?

@cristianoc cristianoc merged commit 3b31eed into rescript-lang:master Jan 30, 2018
@cristianoc cristianoc mentioned this pull request Jan 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobzhang bobzhang bobzhang left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cristianoc @bobzhang